search

servo / saltfs

Salt Stack Filesystem
Apache License 2.0
56 stars 107 forks source link

highstate on the master should run buildbot reconfig #678

Open edunham opened 7 years ago

edunham commented 7 years ago

i highstated to roll out https://github.com/servo/saltfs/issues/674 and expected it to also reconfig. it apparently did not because after highstate the new macs did not show up but after manual reconfig of /home/servo/buildbot/master they did.

http://docs.buildbot.net/0.8.4p2/Reloading-the-Config-File-_0028reconfig_0029.html

aneeshusa commented 7 years ago

AFAIK, we've always had to manually restart Buildbot for it to pick up on config changes - this is noted in our salt docs and the process is on the wiki page. PR/wiki edit for a better warning is welcome :)

I made #505 to automatically queue Buildbot restarts upon deploy, which has since bitrotted - happy to rebase if you want to review. FWIW, I prefer to avoid buildbot reconfig in favor of always restarting Buildbot, as the Buildbot docs mention that reconfig is fragile.