servo / saltfs

Salt Stack Filesystem
Apache License 2.0
56 stars 107 forks source link

Switch to https://build.servo.org #906

Closed Darkspirit closed 5 years ago

Darkspirit commented 5 years ago

@jdm I don't want to just ping you, so I make this pull request. This should help with https://github.com/servo/saltfs/issues/423#issuecomment-429399125, but is not tested with Vagrant.

(Background: servo.org enforces HSTS since bug 1482947 and is ready to be HSTS-preloaded.)


This change is Reviewable

Darkspirit commented 5 years ago

@jdm There is a long list of travis webhooks trying to connect to http://build.servo.org:54856/travis which is already 404 Not Found when accessing with curl. Since #454 Homu is checking build statuses directly at GitHub https://github.com/servo/saltfs/blob/5dcb05a3d75430f3f8a2d78c4485bf0c2494059c/homu/files/cfg.toml#L268-L271 and doesn't rely on Travis webhook notifications, if I'm not wrong: https://github.com/servo/saltfs/blob/5dcb05a3d75430f3f8a2d78c4485bf0c2494059c/homu/files/cfg.toml#L100

Shall I create PRs removing each travis webhook? Or do you want to ignore them?

jdm commented 5 years ago

Removing those unneeded webhook notifications would be useful.

Darkspirit commented 5 years ago

I'll split this to multiple PRs as well.