Closed Darkspirit closed 4 years ago
https://github.com/servo/saltfs/pull/973#issuecomment-517108103
iirc last time I made this change I broke our buildbot CI completely. This will need to wait until I see convincing evidence that that won't happen again.
Do you mean https://github.com/servo/saltfs/pull/913#issuecomment-437125507? You broke it under stress without further notice. :-/ It was like changing http://example.com:80/ to https://example.com:80/. HTTPS is only configured on nginx port 443.
In particular, I believe that there are some python-based HTTP requests for build.servo.org that see a 301 response and raise an exception.
As far as I can see port 80 is only used by web UI. If the transition is done, port 80 can anyway be closed, so I didn't touch it.
This change is
https://github.com/servo/saltfs/pull/973#issuecomment-517108103
Do you mean https://github.com/servo/saltfs/pull/913#issuecomment-437125507? You broke it under stress without further notice. :-/ It was like changing http://example.com:80/ to https://example.com:80/. HTTPS is only configured on nginx port 443.
As far as I can see port 80 is only used by web UI. If the transition is done, port 80 can anyway be closed, so I didn't touch it.
This change is