Closed asajeffrey closed 6 years ago
There are some failures running the performance tests in CI. My diagnosis for what's going on is...
If Servo times out running one of the tests, the script exits (because we have set -o errexit). See, for example http://build.servo.org/builders/linux-nightly/builds/597/steps/test/logs/stdio - note that this exit does not kill the wayback server!
set -o errexit
The next time the nightly tests are run, the old wayback server is running (but in the wrong archive), which causes havoc.
So my proposed fix is
a) warn rather than exit if Servo times out, and b) kill any old wayback servers that might be around before starting the script.
r? @jdm or @aneeshusa
asajeffrey
commented
6 years ago asajeffrey
commented
6 years ago
There are some failures running the performance tests in CI. My diagnosis for what's going on is...
If Servo times out running one of the tests, the script exits (because we have
set -o errexit). See, for example http://build.servo.org/builders/linux-nightly/builds/597/steps/test/logs/stdio - note that this exit does not kill the wayback server!The next time the nightly tests are run, the old wayback server is running (but in the wrong archive), which causes havoc.
So my proposed fix is
a) warn rather than exit if Servo times out, and b) kill any old wayback servers that might be around before starting the script.