servo / servo.org_2014-2020

Main website for Servo.
https://servo.org
Mozilla Public License 2.0
13 stars 31 forks source link

Use customized version of Bootstrap #41

Closed ys-chung closed 7 years ago

ys-chung commented 7 years ago

This fixes the width issue of the languages section mentioned in #36


This change is Reviewable

KiChjang commented 7 years ago

I'm not very enthusiastic about modifying Boostrap itself to achieve the desired result, but I'll defer to @jdm here for the final say.

ys-chung commented 7 years ago

I didn't just go into Bootstrap's code and modify it myself BTW, I just generated it through Bootstrap's official customizer, which the config used can be found here .

jdm commented 7 years ago

I don't know anything about bootstrap, but the official customizer sounds fine.

Coder206 commented 7 years ago

@alphachung What's the purpose of the PR? I was unable to see any signification changes apart from the code structure (and the odd grid change or margin edit) when I tried out your code... Please correct me if the content below is incorrect. It's just based on my observation and a few minutes to spare.

Here is a screenshot of the current page (at Servo.org)

page-shot-2016-11-14 servo the parallel browser engine

Here is a screenshot of your page on my system:

page-shot-2016-12-14 servo the parallel browser engine

I though this was to help with this:

page-shot-2016-11-14 servo the parallel browser engine_current

ys-chung commented 7 years ago

@Coder206 This is the screenshot of the current servo.org on my system:

firefox_screenshot_2016-12-15t02-13-29 373z

This is the screenshot of my page on my system:

firefox_screenshot_2016-12-15t02-13-44 216z

Coder206 commented 7 years ago

@alphachung Oh I see! Small details, not sure why mine didn't have it. (Perhaps I took to the wrong picture) Sorry about that!