Update glx dependency to 0.2 - Githubissues

servo / skia

Skia

BSD 3-Clause "New" or "Revised" License

109 stars 61 forks source link

Update glx dependency to 0.2 #145

Closed MortimerGoro closed 6 years ago

MortimerGoro commented 6 years ago

See https://github.com/servo/rust-glx/pull/17 and servo/gleam#130. We also need this to avoid duplicated versions tidy check failures in order to land the new gleam version in Servo.

This change is

MortimerGoro commented 6 years ago

r? @jdm

jdm commented 6 years ago

@bors-servo: r+

bors-servo commented 6 years ago

:pushpin: Commit 0240688 has been approved by jdm

bors-servo commented 6 years ago

:hourglass: Testing commit 02406889f1d27b0a96cb5b75f07ed6cca72745e2 with merge b35da8446b8889a6f605e912d5d0fc1397678c31...

bors-servo commented 6 years ago

:broken_heart: Test failed - status-travis

MortimerGoro commented 6 years ago

This job was cancelled because the "Auto Cancellation" feature is currently enabled, and a more recent build (#361) for branch auto came in while this job was waiting to be processed.

jdm commented 6 years ago

@bors-servo: retry

bors-servo commented 6 years ago

:hourglass: Testing commit 02406889f1d27b0a96cb5b75f07ed6cca72745e2 with merge 8a07935e3fcd65a971af028f06c509737523b19d...

bors-servo commented 6 years ago

:sunny: Test successful - status-travis Approved by: jdm Pushing 8a07935e3fcd65a971af028f06c509737523b19d to master...

nox commented 6 years ago

Why was that a breaking bump…?

MortimerGoro commented 6 years ago

Why was that a breaking bump…?

Includes major version bump of rust-glx (https://github.com/servo/rust-glx/pull/17) and exports some glx context classes:

pub mod gl_context_glx;
pub mod gl_rasterization_context_glx;

I see that internal gl_context_glx symbols aren't pub though, so probably could have avoided the breaking bump.