servo / string-cache

String interning for Rust
Apache License 2.0
194 stars 77 forks source link

Use a custom Visitor in Deserialize #241

Closed Lucretiel closed 2 years ago

Lucretiel commented 3 years ago

This PR implements a simple custom de::Visitor for Atom, which allows for deserializing without unnecessary round-trips through a String.

jdm commented 2 years ago

@bors-servo r+

bors-servo commented 2 years ago

:pushpin: Commit 58d0c57 has been approved by jdm

bors-servo commented 2 years ago

:hourglass: Testing commit 58d0c572db093c751797bb50c482f8375396cc7c with merge 9d78d419417f60145e4494f52e3032b507ce7aca...

bors-servo commented 2 years ago

:broken_heart: Test failed - checks-github

jdm commented 2 years ago

Sigh. Our minimum supported rust version has been broken by a new minor version for the instant crate.

jdm commented 2 years ago

@bors-servo retry

bors-servo commented 2 years ago

:hourglass: Testing commit 58d0c572db093c751797bb50c482f8375396cc7c with merge 7400886b8b5f47f934a993629a21962411e1bbc2...

bors-servo commented 2 years ago

:sunny: Test successful - checks-github Approved by: jdm Pushing 7400886b8b5f47f934a993629a21962411e1bbc2 to master...