search

servo / stylo

39 stars 11 forks source link

Added support of style & color for `text-decoration` #29

Closed MunishMummadi closed 3 months ago

MunishMummadi commented 3 months ago

Changes Made:

  1. Updated the sub_properties attribute of the text-decoration shorthand to include text-decoration-style and text-decoration-color for the Servo engine.

  2. Modified the parse_value function to parse text-decoration-style and text-decoration-color properties when the engine is Servo. The parsed values are stored in the style and color variables, respectively.

  3. Updated the ToCss implementation to serialize text-decoration-style and text-decoration-color properties for the Servo engine.

These changes ensure that the text-decoration shorthand in Servo correctly parses and serializes the text-decoration-style and text-decoration-color properties, providing a complete implementation of the shorthand.

Resolves: #25

MunishMummadi commented 3 months ago

I forgot to check it clearly. Sorry I will update it.

MunishMummadi commented 3 months ago

@Loirooriol Does the changes meet expectations!!!

MunishMummadi commented 3 months ago

Hey @Loirooriol .Sorry for the delay. I don't know whether I am going in the correct direction or not. Here is the revised version of the code. Let me know what do you think. Edit: Removed Code

Loirooriol commented 3 months ago

I can't review like that, please just update the PR.

MunishMummadi commented 3 months ago

I am really Sorry for making you feel like that. I can strongly say that I haven't used any AI for writing the code. Thank You.