search

servo / stylo

74 stars 16 forks source link

Add `securitypolicyviolation` to servo_atoms #59

Closed chocolate-pie closed 2 months ago

chocolate-pie commented 2 months ago

Add securitypolicyviolation to servo_atoms for initial support for servo/servo#25182.

mrobinson commented 2 months ago

It feels wrong that we are adding Servo-specific atoms to Stylo. Is there a way that Servo can use its own atoms, perhaps by moving Servo-specific atoms to a crate within Servo?

chocolate-pie commented 2 months ago

More specifically, I'd like to use these atoms to support unsafe-eval and wasm-unsafe-eval directive as in https://github.com/chocolate-pie/servo/tree/support-unsafe-eval. (used in https://github.com/chocolate-pie/servo/commit/c91863e01d33d3f40de302e677f2bf39417e3d57#diff-f6f97d491c49631b6f3c2079b380fb1db37087a0ee13a14c7e9a5c0969c81a6eR81) I'm concerning servo-specific atoms will become incompatible with stylo-specific atoms, but is there any problem to separate atoms into servo?

chocolate-pie commented 2 months ago

I tried for several hours to see if I could replace the atom with one from servo, but could not.

chocolate-pie commented 2 months ago

Closing in favor of servo/servo#32887. I'll use Atom::from instead for a while.