Fix some simple clippy lints

servo / surfman

Accelerated offscreen graphics for WebGL

Apache License 2.0

172 stars 84 forks source link

Fix some simple clippy lints #284

Closed jschwe closed 5 months ago

jschwe commented 5 months ago

Each lint was fixed in an individual commit, for easier review.

After this PR clippy is warning free when run on surfman, examples are excluded and the following lints are allowed:

clippy::missing_safety_doc
clippy::unnecessary_cast
clippy::result_large_err
clippy::mismatched_target_os
clippy::unnecessary_mut_passed
clippy::drop_non_drop

jschwe commented 5 months ago

It would also be nice to add a clippy run to GitHub Actions to ensure that these don't regress.

I agree - but I think the examples need to be fixed first (they are not compiling, and cause clippy to fail). Locally, I just ignored the issue by deleted the examples folder.