Add initial support for OpenHarmony

servo / surfman

Accelerated offscreen graphics for WebGL

Apache License 2.0

172 stars 84 forks source link

Add initial support for OpenHarmony #293

Closed jschwe closed 3 months ago

jschwe commented 4 months ago

Follow-up PR to #285.

Todo:

Is platform/egl really the best name for the shared code?
It would be great if someone else could test the changes on android - I couldn't get the servo android build to work on my personal machine (unrelated to these changes)

mrobinson commented 3 months ago

This is looking great. I tested the Android build locally and it compiled. I didn't test it in an emulator.

I suppose this is just blocked on a new raw-window-handle release now.

jschwe commented 3 months ago

I suppose this is just blocked on a new raw-window-handle release now.

Ah, actually raw-window-handle 0.6.2. is already released, I just forgot to update this PR after the release. I adjusted the PR to use rwh 0.6.2 and added the missing code for ohos.

mrobinson commented 3 months ago

Is this still a draft or is it okay to merge this?

jschwe commented 3 months ago

It's okay to merge from my side. Should I squash the review changes into the second commit, or will you squash everything into one commit anyway?

mrobinson commented 3 months ago

The merge queue automatically squashes commits, so it shouldn't be an issue. Thanks!