search

servo / surfman

Accelerated offscreen graphics for WebGL
Apache License 2.0
172 stars 84 forks source link

chore: Switch out winapi to windows-rs #298

Open dklassic opened 2 months ago

dklassic commented 2 months ago

Closes #292.

I'm still validating the change so I'll put it as a draft for now.

mrobinson commented 2 months ago

@dklassic It looks like there are still some build failures here depending on the features passed.

dklassic commented 2 months ago

oops seems like I missed migrating winapi used in angle.

I'm out for a small trip I'll continue to cleanup the rest once I'm back.

wusyong commented 1 month ago

Just realized webxr repo also has to be tested :/

msub2 commented 1 month ago

I have a WIP branch for updating webxr crate to windows/windows-sys, happy to assist with testing this if it's ready

wusyong commented 1 month ago

@msub2 Do you have a branch for it? Perhaps we can open a draft in webxr repo to test in CI.

msub2 commented 1 month ago

I can push one up soon, I'm currently using this branch of surfman on my WIP branch for webxr and just need to fix a couple more spots related to d3d11 textures

msub2 commented 1 month ago

hrmm, I've got the webxr crate building now but trying to test in servo with updated surfman is causing an immediate crash. ill put up a draft pr for now, still needs looking into though

https://github.com/servo/webxr/pull/238

msub2 commented 1 month ago

Specifically the crash is happening in components/shared/webrenderer/rendering_context.rs in the create function in Servo