search

servo / surfman

Accelerated offscreen graphics for WebGL
Apache License 2.0
173 stars 84 forks source link

Workspace removal broke publishing #302

Open jdm opened 3 months ago

jdm commented 3 months ago

There are several issues:

  1. the workspace removal and subsequent restructuring broke a number of symlinks that are present in the android-example subdirectory (https://github.com/servo/surfman/tree/main/android-example/app/src/main/assets and https://github.com/servo/surfman/tree/main/android-example/app/src/main/jniLibs/arm64-v8a)
  2. cargo publish attempts to verify that all files in android-example are actually present, so we can't publish without fixing the first issue
  3. the changes in 1a522fac8519074177bddab32643ec6426b1e85f broke android-example compilation (incidentally, renaming a public module should have been a breaking change and caused 0.10.0)
  4. android-example compilation is no longer verified in CI, so we didn't detect issue 3
jdm commented 3 months ago

I worked around this for 0.9.5 by fixing the assets symlinks, unlinking the missing .so, and running with --allow-dirty.

jschwe commented 2 months ago

Just a note - the android example was already broken. We definitely should add cargo semver checks to CI though.