search

servo / taskcluster-config

Taskcluster configuration for Servo
1 stars 2 forks source link

Task creation fails for PR events when branch base is older than 2019-11-05 #2

Closed jdm closed 4 years ago

jdm commented 4 years ago

The following scopes are missing when trying to create an untrusted task in a PR in servo/servo right now:

{
  "AnyOf": [
    {
      "AnyOf": [
        "queue:create-task:highest:aws-provisioner-v1/servo-docker-untrusted",
        "queue:create-task:very-high:aws-provisioner-v1/servo-docker-untrusted",
        "queue:create-task:high:aws-provisioner-v1/servo-docker-untrusted",
        "queue:create-task:medium:aws-provisioner-v1/servo-docker-untrusted",
        "queue:create-task:low:aws-provisioner-v1/servo-docker-untrusted",
        "queue:create-task:very-low:aws-provisioner-v1/servo-docker-untrusted",
        "queue:create-task:lowest:aws-provisioner-v1/servo-docker-untrusted"
      ]
    },
    {
      "AnyOf": [
        "queue:create-task:aws-provisioner-v1/servo-docker-untrusted",
        {
          "AllOf": [
            "queue:define-task:aws-provisioner-v1/servo-docker-untrusted",
            "queue:task-group-id:taskcluster-github/CRJtbx1GT9ulfXgLfF4gFA",
            "queue:schedule-task:taskcluster-github/CRJtbx1GT9ulfXgLfF4gFA/CRJtbx1GT9ulfXgLfF4gFA"
          ]
        }
      ]
    }
  ]
}

As far as I can tell, updating the name should fix it?

jdm commented 4 years ago

r? @SimonSapin

jdm commented 4 years ago

Example failure: https://github.com/servo/servo/pull/24664#commitcomment-35875424

SimonSapin commented 4 years ago

This won’t fix the issue: the correct name is indeed docker-untrusted without the servo- prefix, and aws-provisioner-v1 is not used anymore:

https://github.com/mozilla/community-tc-config/blob/ea76ecf1d3f976b1c49f5df9655905c062bb8242/config/projects.yml#L216-L223

It looks like the branch of this PR starts from an old commit of master that doesn’t have this change:

https://github.com/servo/servo/pull/24652/files#diff-ac0229d1171c0983b27003af4c7441a5R70-R73

Indeed, for PR events tc-github looks at the .taskcluster.yml file in the “head” commit of the PR, not the “merge”:

https://github.com/taskcluster/taskcluster/blob/5cf30481fe09b5dbc8b438b144972d545f3339cd/services/github/src/handlers.js#L551-L569

Maybe that should change. In the meantime, the work-around is to rebase the PR. Or to simply ignore those errors: Homu should not be affected by this.

SimonSapin commented 4 years ago

Maybe that should change

https://bugzilla.mozilla.org/show_bug.cgi?id=1539523 was already requesting this.

SimonSapin commented 4 years ago

Closing as there’s nothing to do here as far as I can tell.