search

servo / unicode-bidi

Implementation of the Unicode Bidirection Algorithm in Rust
Other
77 stars 33 forks source link

Add serde support and bump version to 0.3.0 #31

Closed behnam closed 7 years ago

behnam commented 7 years ago

Add with_serde feature, which implements serde for the new struct Level, mainly used in servo, supporting serde 0.8, 0.9 and 1.0.

Add tests for the with_serde feature. The serde_tests modules only works for serde:>=1.0, though.

servo has dependency on the loose implementation of visual_runs(), which couldn not be improved without breaking the API, as it needs more information to process the levels correctly, and the call-site in servo does not have all the information needed and needs a non-trivial change to work with the new improved version. Therefore, I have moved the old version to a deprecated module, to be used for now until servo is fixed and we drop the old implementation.

Bump version to 0.3.0, as we now ready for a release: can build servo (patch ready) and idna crates.

This change is Reviewable

behnam commented 7 years ago

Okay, addressed all the comments, plus merging a couple of consequent cfg() calls together.

behnam commented 7 years ago

Review status: 0 of 4 files reviewed at latest revision, 3 unresolved discussions.

Cargo.toml, line 20 at r1 (raw file):

Previously, mbrubeck (Matt Brubeck) wrote…
Please make these dependencies `">=0.8, <2.0".

Done.

src/deprecated.rs, line 17 at r1 (raw file):

Previously, mbrubeck (Matt Brubeck) wrote…
s/perfor/perform/

Done.

Comments from Reviewable

mbrubeck commented 7 years ago

@bors-servo r+

bors-servo commented 7 years ago

:pushpin: Commit efa3b2a has been approved by mbrubeck

bors-servo commented 7 years ago

:hourglass: Testing commit efa3b2aa3fde12aabb43a485168b85e3c0d910a1 with merge 011d7cf7005a7b4819bb983c8b193f1a733116f6...

bors-servo commented 7 years ago

:sunny: Test successful - status-travis Approved by: mbrubeck Pushing 011d7cf7005a7b4819bb983c8b193f1a733116f6 to master...

behnam commented 7 years ago

@mbrubeck, how these packages get posted on crates.io? Looks like it's manual. Could you please publish 0.2.6 and 0.3.0? Also, we need to tag the commits in git.

Also, are there any projects automating this: releasing on crates.io from travis based on git tags?

mbrubeck commented 7 years ago

Tagged and published. @behnam, would you like to be added as a contributor/owner of this package so that you can publish new versions yourself?

behnam commented 7 years ago

Thanks, @mbrubeck. Well, why not! Would makes things easier for both of us! :)