Closed behnam closed 7 years ago
Okay, addressed all the comments, plus merging a couple of consequent cfg()
calls together.
Review status: 0 of 4 files reviewed at latest revision, 3 unresolved discussions.
Cargo.toml, line 20 at r1 (raw file):
Please make these dependencies `">=0.8, <2.0".
Done.
src/deprecated.rs, line 17 at r1 (raw file):
s/perfor/perform/
Done.
Comments from Reviewable
@bors-servo r+
:pushpin: Commit efa3b2a has been approved by mbrubeck
:hourglass: Testing commit efa3b2aa3fde12aabb43a485168b85e3c0d910a1 with merge 011d7cf7005a7b4819bb983c8b193f1a733116f6...
:sunny: Test successful - status-travis Approved by: mbrubeck Pushing 011d7cf7005a7b4819bb983c8b193f1a733116f6 to master...
@mbrubeck, how these packages get posted on crates.io? Looks like it's manual. Could you please publish 0.2.6
and 0.3.0
? Also, we need to tag the commits in git.
Also, are there any projects automating this: releasing on crates.io from travis based on git tags?
Tagged and published. @behnam, would you like to be added as a contributor/owner of this package so that you can publish new versions yourself?
Thanks, @mbrubeck. Well, why not! Would makes things easier for both of us! :)
Add
with_serde
feature, which implements serde for the newstruct Level
, mainly used inservo
, supporting serde0.8
,0.9
and1.0
.Add tests for the
with_serde
feature. Theserde_tests
modules only works forserde:>=1.0
, though.servo
has dependency on the loose implementation ofvisual_runs()
, which couldn not be improved without breaking the API, as it needs more information to process the levels correctly, and the call-site inservo
does not have all the information needed and needs a non-trivial change to work with the new improved version. Therefore, I have moved the old version to adeprecated
module, to be used for now untilservo
is fixed and we drop the old implementation.Bump version to
0.3.0
, as we now ready for a release: can buildservo
(patch ready) andidna
crates.This change is![Reviewable](https://reviewable.io/review_button.svg)