Closed behnam closed 7 years ago
Done.
Review status: 0 of 7 files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
@bors-servo r+
:pushpin: Commit bacbb67 has been approved by mbrubeck
:hourglass: Testing commit bacbb67c4c7aec66542429606f7c80c118807f3c with merge c2603e2ae37825f820eb227391ce7ce7c752855a...
:sunny: Test successful - status-travis Approved by: mbrubeck Pushing c2603e2ae37825f820eb227391ce7ce7c752855a to master...
Improve basic conformance by fixing steps X10, N1/N2, L1
Continue my review of code based on spec and fix various steps that drop the basic conformance failures from 12827 to 250.
X10: Fix incorrect index for
succ_level
resolution (off byend_of_seq
because of sub-sequencing) and add unit tests from the spec text, from both BD13 and X10 sections.N1/N2: Fix resetting rule for NI levels by definint
e
, as noted in the spec.L1: Fix not resetting leading whitespace/formatting chars in a line.
[tests/conformance] Use non-ASCII sample chars
gen_char_from_bidi_class()
, which increases the failure rate from 250 to 314.[lib] Impl BidiInfo.reordered_levels_per_char()
[lib] reorder_line(): Expand LTR-only shortcut condition
This change is