servo / unicode-bidi

Implementation of the Unicode Bidirection Algorithm in Rust
Other
74 stars 34 forks source link

Improve basic conformance and add more unit tests #36

Closed behnam closed 7 years ago

behnam commented 7 years ago

Improve basic conformance by fixing steps X10, N1/N2, L1

Continue my review of code based on spec and fix various steps that drop the basic conformance failures from 12827 to 250.

[tests/conformance] Use non-ASCII sample chars

[lib] Impl BidiInfo.reordered_levels_per_char()

[lib] reorder_line(): Expand LTR-only shortcut condition


This change is Reviewable

behnam commented 7 years ago

Done.


Review status: 0 of 7 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

mbrubeck commented 7 years ago

@bors-servo r+

bors-servo commented 7 years ago

:pushpin: Commit bacbb67 has been approved by mbrubeck

bors-servo commented 7 years ago

:hourglass: Testing commit bacbb67c4c7aec66542429606f7c80c118807f3c with merge c2603e2ae37825f820eb227391ce7ce7c752855a...

bors-servo commented 7 years ago

:sunny: Test successful - status-travis Approved by: mbrubeck Pushing c2603e2ae37825f820eb227391ce7ce7c752855a to master...