Improve CI and update serde feature name

servo / unicode-bidi

Implementation of the Unicode Bidirection Algorithm in Rust

Other

74 stars 34 forks source link

Improve CI and update serde feature name #42

Closed behnam closed 7 years ago

behnam commented 7 years ago

Summary: Development improvements, with no API or functionality changes.

We already follow most of the items from the Rust API guildeline. In this stack, I fix one case that's fairly trivial and easily backward-compatible: use serde as feature name for enabling serde, instead of home-brew with_serde.
The shortcut I put in travis.yml script section was causing false positives in 100% of executions (oops!), which is now fixed by a more verbose conditioning, but accurate.
Add appveyor.yml, as many packages depending on this package already require stable windows builds.

This change is

KiChjang commented 7 years ago

What's the flame-udhr-graph.html about?

behnam commented 7 years ago

What's the flame-udhr-graph.html about?

Oops. That's not supposed to be there. It's the output of flame_udhr example.

behnam commented 7 years ago

Okay, fixed.

Now, one question about AppVeyor, though: does it need any setup on the Servo devops side? Anything needs to be done before/after enabling it for a repo?

KiChjang commented 7 years ago

I still see flame-udhr-graph.html being listed under the files tab...

behnam commented 7 years ago

Uh.... pushed again and checked the files tab here, now it's gone! Also added /*.html to .gitignore so it won't happen again. Thanks, @KiChjang !

behnam commented 7 years ago

Since @mbrubeck already reviewed and @KiChjang double-checked the update...

@bors-servo r+

bors-servo commented 7 years ago

:pushpin: Commit a0f2072 has been approved by behnam

bors-servo commented 7 years ago

:hourglass: Testing commit a0f207220e30542f2cb56c539036bb8b1c4cc203 with merge a2d479525517120c3ed712ff414e540170798dac...

bors-servo commented 7 years ago

:sunny: Test successful - status-travis Approved by: behnam Pushing a2d479525517120c3ed712ff414e540170798dac to master...

mbrubeck commented 7 years ago

Now, one question about AppVeyor, though: does it need any setup on the Servo devops side? Anything needs to be done before/after enabling it for a repo?

I don't know. I don't seem to have access to add new projects for the servo organization in AppVeyor.

behnam commented 7 years ago

Yeah, I couldn't figure out how to manage repos for any organizations, even the ones I own. I think we can bug the devops team later about it. You think I should file a bug/issue for it?

mbrubeck commented 7 years ago

Yes, please.