servo / unicode-bidi

Implementation of the Unicode Bidirection Algorithm in Rust
Other
74 stars 34 forks source link

Add pluggable data #67

Closed Manishearth closed 2 years ago

Manishearth commented 2 years ago

Adds a trait that makes the data pluggable, and defines a default hardcoded-data feature.

We shouldn't release this just yet, I'd like to also perform a Unicode 14 update.

cc @younies

younies commented 2 years ago

@Manishearth , thanks :)

mbrubeck commented 2 years ago

Could you add some additional #[cfg] to fix up the remaining "unused" warnings when the new feature is disabled?

Feel free to move things into modules to reduce the number of cfg attributes needed.

Manishearth commented 2 years ago

Done!

Manishearth commented 2 years ago

Thanks!