search

servo / unicode-bidi

Implementation of the Unicode Bidirection Algorithm in Rust
Other
77 stars 33 forks source link

Initial review #7

Closed SimonSapin closed 9 years ago

SimonSapin commented 9 years ago

I reviewed 51fde5d3375790cd52cfcaa4a6d0b30d08489574 / v0.1.5 against revision 33 of the spec, and made changes as I went along.

This is not to be merged as-is, please see inline comments.

Closes #4.

mbrubeck commented 9 years ago

Responded to review comments on 72e465a477721a3de45b3c1fdcc04fb670725a13. I can submit a new PR to add comments and fixes as noted above. Or, if you prefer, you can amend this PR and I can review it.

mbrubeck commented 9 years ago

Moving to #10.