servo / unicode-bidi

Implementation of the Unicode Bidirection Algorithm in Rust
Other
74 stars 34 forks source link

Add the needed APIs for Skia #72

Closed younies closed 2 years ago

younies commented 2 years ago

closes: https://github.com/unicode-org/icu4x/issues/1733

Manishearth commented 2 years ago

A lot of these APIs take in an &ParagraphInfo and what we might do is build a struct Paragraph<'a> that contains both a BidiInfo and ParagraphInfo and add methods there

bors-servo commented 2 years ago

:umbrella: The latest upstream changes (presumably #73) made this pull request unmergeable. Please resolve the merge conflicts.

bors-servo commented 2 years ago

:umbrella: The latest upstream changes (presumably #74) made this pull request unmergeable. Please resolve the merge conflicts.

Manishearth commented 2 years ago

@bors-servo r+

bors-servo commented 2 years ago

:pushpin: Commit bb0743b has been approved by Manishearth

bors-servo commented 2 years ago

:hourglass: Testing commit bb0743b4fa018d740f25c14db7c0b3a38e12f617 with merge 98564c65b1aadb8e4ea671b4a3e8282f8ae3de79...

bors-servo commented 2 years ago

:sunny: Test successful - checks-github, status-appveyor Approved by: Manishearth Pushing 98564c65b1aadb8e4ea671b4a3e8282f8ae3de79 to master...