servo / webrender

A GPU-based renderer for the web
https://doc.servo.org/webrender/
Mozilla Public License 2.0
3.14k stars 279 forks source link

Different versions #3654

Open ghost opened 5 years ago

ghost commented 5 years ago

Why are the 0.60 versions, github and cargo.io will be different

[dependencies] webrender ={ git = "https://github.com/servo/webrender"}

    pub fn read_pixels_into_pbo(
        &mut self,
        read_target: ReadTarget,
        rect: DeviceIntRect,
        format: ImageFormat,
        pbo: &PBO,
    ) {

[dependencies] webrender ="0.60.0"

gl.rs:

    pub fn read_pixels_into(
        &mut self,
        rect: DeviceIntRect,
        format: ReadPixelsFormat,
        output: &mut [u8],
    ) {
kvark commented 5 years ago

Github is ahead but didn't yet bump the version number. There are different workflows of versioning: some projects bump the version on the first breaking change (which has a disadvantage of needing to check if it was bumped already). Others synchronize bumping the version with publishing the crate (which leads to the confusion you are expressing). I don't think there is a perfect workflow out there...

Best practices typically involve tagging a published version and/or branching on a breaking change in order to allow patch PRs. This is something this repo is missing, although other Servo projects (gleam, plane-split, etc) do try to keep the tags actual. We'll try to be better.

ghost commented 5 years ago

Thank you very much, I know why, I like this project very much, I hope this project is getting better and better.@kvark