Open tsfraser opened 1 year ago
Yeah some snapshots from sims use [0,Boxsize) - the convention the code expects - and some (0,Boxsize] (and some have forgotten to do a final wrapping) for the coordinates. A hack for this is to put 2000.01 as the boxsize, but some snapshots might have negative positions if they forgot to wrap so its a good idea is to not assume input is perfect and always wrap the coordinates in the code (this does not take any time) i.e. x = (x + Boxsize) % Boxsize etc. Then we ensure everything is in [0,Boxsize) and avoids this issue alltogether.
Triggers when running AbacusSummit mocks, especially for the 1000 HOD mocks per cosmology. Axis in the error refers to the specific column in the coordinate array that's passed to allocate_gal_cic (i.e. in this case z has a single value at 2000.0 instead of 1999.9, which for a boxsize of 2000 is enough to trigger this). Will also flag this with Abacus, since their parameter space is 0<xyz<=2000 instead of 0<xyz<2000 since I'm assuming several codes are built around the latter assumption?