[BUG] no sound in video

session-foundation / session-ios

A private messenger for iOS.

https://getsession.org

GNU General Public License v3.0

3 stars 1 forks source link

[BUG] no sound in video #26

Closed qdhj closed 9 months ago

qdhj commented 10 months ago

Code of conduct

[X] I have read and agree to adhere to the Code of Conduct

Current Behavior

No sound in videos posted in SOGS, when the phone is in the silent mode (the switch on the side), even the sound is on.

Steps To Reproduce

Turn the switch on the side to silent
Open any video

iOS Version

iOS 17.1.1

Session Version

3.4.4 (428)

mpretty-cyro commented 9 months ago

Hey @qdhj, thanks for reporting this issue - I was wondering if you could provide some more information about the video you're having issues with to help us narrow down the issue? • Is this a video you uploaded to the community? • If you did upload it, is it one you recorded within Session or a video you already had on your phone? • If you save the video (it will save to the Photos app) and play it there, does it have sound then? • Do you have Session on another platform (Android/Desktop) and if so, does the video have sound when you play it on one of those?

qdhj commented 9 months ago

Hey @qdhj, thanks for reporting this issue - I was wondering if you could provide some more information about the video you're having issues with to help us narrow down the issue? • Is this a video you uploaded to the community? • If you did upload it, is it one you recorded within Session or a video you already had on your phone? • If you save the video (it will save to the Photos app) and play it there, does it have sound then? • Do you have Session on another platform (Android/Desktop) and if so, does the video have sound when you play it on one of those?

Uploaded to community from PC.
Recorded on PC.
When I long-hold the message and press "save", saved video has the sound.
Opening a video from android, PC and macOS gives the sound OK.

mpretty-cyro commented 9 months ago

Hey @qdhj thanks for providing more information - do you happen to have the your phone in silent mode (the switch on the side)?

Doing some testing on my side I was able to reproduce it but only when playing the video while the switch was set to silent mode, I've created a PR to fix this case (https://github.com/oxen-io/session-ios/pull/951) but it would be good if you have the chance to confirm whether the audio plays correctly when silent mode is disabled

qdhj commented 9 months ago

Hey @qdhj thanks for providing more information - do you happen to have the your phone in silent mode (the switch on the side)?

Doing some testing on my side I was able to reproduce it but only when playing the video while the switch was set to silent mode, I've created a PR to fix this case (#951) but it would be good if you have the chance to confirm whether the audio plays correctly when silent mode is disabled

yes, it indeed only happens when the phone is in silent mode (even though the sound is on)! greatly spotted the origin of the bug.

qdhj commented 9 months ago

Happens to be a dublicate of https://github.com/oxen-io/session-ios/pull/951