session-foundation / session-ios

A private messenger for iOS.
https://getsession.org
GNU General Public License v3.0
4 stars 1 forks source link

Read Receipt's Completely Broken #84

Closed GittyUpMyHorsey closed 7 months ago

GittyUpMyHorsey commented 1 year ago

Unfortunately read receipt's are completely broken in session on ios. I actually think it goes one step further into the realm of they might actually only be mislabelled (in the app) delivery notification indicators only.

I have read receipts enabled in privacy settings (I am on the latest ios mobile app), I have fast mode enabled, all 9 of my dm friends in session have read receipts enabled some on the andriod mobile app some on the ios mobile app (all running the latest version as of posting this).

None of us get read receipts for each other. The only two icons that are ever seen are:

I even proceeded to verify this in the session community support group with two random people who wanted to test with me, who also had read receipts enabled. This bug was/is present with both of them as well. *side note, the issue goes even deeper, as one of the randos tested with in the community group had an extra related issue on top of this, with them, when I sent a message, I could see the receipt indicators showing the checkmark, then as soon as the other party read the message, my delivery notification circle disappeared from that chat entirely, inside the chat itself and back on the main screen in the chat list.

GittyUpMyHorsey commented 1 year ago

Read receipts still not working, any updates?

Thanks.

mpretty-cyro commented 1 year ago

Read receipts still not working, any updates?

Thanks.

Sorry on the delay, I've included a fix for this in 2.2.6 - there was an issue where we were marking messages as read before sending read receipts and the "send read receipt" process was ignoring any messages that had already been marked as read

side note, the issue goes even deeper, as one of the randos tested with in the community group had an extra related issue on top of this, with them, when I sent a message, I could see the receipt indicators showing the checkmark, then as soon as the other party read the message, my delivery notification circle disappeared from that chat entirely, inside the chat itself and back on the main screen in the chat list.

If you see this issue again in the 2.2.6 (once available) please feel free to open a new issue for it

KeeJef commented 1 year ago

I think this may still be occurring, seems like iOS devices still aren't sending read receipts, but are interpreting read receipts sent from other clients

GittyUpMyHorsey commented 1 year ago

Just updated and had my friend update to 2.2.6 and it's semi working but still not fully functional.

Read receipts are working with a session developer I am chatting with but not working in my friend and I's one to one chat. We are both running the latest version.

Also functionality is still a little broken as when I see a read indicator, it should stick with the last message I sent until I come back into the chat and write another one, but as soon as the other party replies, the read indicator disappears from inside the chat, which means if I'm not in the chat when the users responds to see the indicator change from sent to seen, then it disappears once their response is added to the chat.

mpretty-cyro commented 1 year ago

Just updated and had my friend update to 2.2.6 and it's semi working but still not fully functional.

Read receipts are working with a session developer I am chatting with but not working in my friend and I's one to one chat. We are both running the latest version.

I came across a few edge-cases in oxen-io/session-ios#784 which could result in flakey behaviour with read receipts, it might be good to take another look once that has been released to see if it has resolved the problem

Just updated and had my friend update to 2.2.6 and it's semi working but still not fully functional.

Read receipts are working with a session developer I am chatting with but not working in my friend and I's one to one chat. We are both running the latest version.

Also functionality is still a little broken as when I see a read indicator, it should stick with the last message I sent until I come back into the chat and write another one, but as soon as the other party replies, the read indicator disappears from inside the chat, which means if I'm not in the chat when the users responds to see the indicator change from sent to seen, then it disappears once their response is added to the chat.

This behaviour has been changed in oxen-io/session-ios#784 (The last outgoing message will now always show it's status)

GittyUpMyHorsey commented 1 year ago

Perfect thank you! I assume this will be 2.2.8?

mpretty-cyro commented 1 year ago

Yep the additional fixes/tweaks are included in 2.2.8 and should make these behave much more reliably on iOS

mpretty-cyro commented 1 year ago

@GittyUpMyHorsey Are you still running into these issues in the latest version of Session?

mpretty-cyro commented 7 months ago

Closing this due to inactivity