session-foundation / session-ios

A private messenger for iOS.
https://getsession.org
GNU General Public License v3.0
4 stars 1 forks source link

[BUG] No option to delete messages on IOS. #97

Closed Bigbrother84844 closed 1 year ago

Bigbrother84844 commented 1 year ago

Code of conduct

Self-training on how to write a bug report

Is there an existing issue for this?

Current Behavior

I can delete messages on the Session desktop, but not on IOS. I long press the message but there is no delete option on IOS, Just reply and copy. session-attachment-2022-12-15-174334

Expected Behavior

I hope the developers will fix this issue soon.

Steps To Reproduce

No response

iOS Version

ios 16.2

Session Version

2.2.4

Anything else?

session-attachment-2022-12-15-174334

RyanRory commented 1 year ago

Hi @Bigbrother84844, thanks for the report. Is it happening in community chats, groups chats, or 1-1 chats? Did you send the message in the screenshot from desktop and the iOS is a linked device?

ghost commented 1 year ago

I can reproduce this bug with Session iOS 2.2.4 and 2.2.5.

I believe it is Community only. Deletion works fine with closed group / 1-1 DM chat.

I suspect it has the same root cause as https://github.com/oxen-io/session-ios/issues/768 where there's some mismatching (or missing value) of one's own blinded ID / one's own unblinded ID which triggers an incorrect conditional branch that does not render the deletion button.

GittyUpMyHorsey commented 1 year ago

I can also reproduce this on the latest ios version with the latest session version.

Delete appears in 1 to 1 and group chats just not community chats.

RyanRory commented 1 year ago

Hi guys, this issue should be fixed in our latest release 2.2.6. Thanks for helping us debug this issue. I'll close this issue now.

ghost commented 1 year ago

Thanks for the fix!

I retested this one with 2.2.6, new message sent to Community can be deleted, old message that existed before the new release can not be deleted, I guess there's nothing we can do with the old message? If that's the case I'm fine, just report my findings.

ghost commented 1 year ago

Actually what's interesting:

It seems like we have a lot of combinations to test, like the ones in https://github.com/oxen-io/session-desktop/issues/2655#issuecomment-1401403829

@RyanRory should we reopen this issue?

mpretty-cyro commented 1 year ago

Hmm - yep will reopen

mpretty-cyro commented 1 year ago
  • If the original message was sent from Desktop, then I can't delete it from iOS

🤦 forgot about ID Blinding - I'll open a PR for this now

ghost commented 1 year ago

This one is fixed for me in Session iOS 2.2.8

mpretty-cyro commented 1 year ago

Fixed in oxen-io/session-ios#795