search

sestoft / C5

C5 generic collection library for C#/.NET
http://www.itu.dk/research/c5/
MIT License
1.03k stars 181 forks source link

A better fix! #16

Closed T145 closed 11 years ago

T145 commented 11 years ago

An improvement over the previous pull! :palm_tree: Hope it helps!

ondfisk commented 11 years ago

Showing 106 changed files with 45,667 additions and 98,547 deletions.

We cannot accept your pull request as the diff shows a wall of pink and we cannot overview your changes properly.

http://www.hanselman.com/blog/YoureJustAnotherCarriageReturnLineFeedInTheWall.aspx

Please fix this and request again.

T145 commented 11 years ago

Yes, I can see your point; let me clarify what those brute changes are. The format commits (e9fd48e, bf4d644, & 514f5db) are nothing but "aesthetic" commits that change the way the code looks; there are no real changes in them. They basically reverse commit aa71483cd6fde17f0e1e11406e64512fb17237e9, and make the code look more readable and consistent. The actual adjustments in the code that I believe your looking for are in the other commits. Those basically just remove unused variables and a bunch of warnings and errors that occur across various platforms and in newer IDEs. I've conducted excessive tests on the changed code as well, and everything works perfectly. The actual changes I plan on adding will come shortly, I just wanted to get the annoying stuff out of the way first. :P

Also, try out the tagging and releasing features that GitHub offers. They help out a lot and you can use releases to provide compiled binaries easily for everyone!

ondfisk commented 11 years ago

Ok. Looking forward to seeing what you've got.

T145 commented 11 years ago

Would it help to do the formatting all in one commit and then do the changes in consecutive commits?

ondfisk commented 11 years ago

The current formatting is there for a reason. The previous authors have chosen to do it this way. Changing the formatting to fit your particular preferences does not help the project in any way. Also you have emptied the .gitattributes file and removed a lot for .gitignore. How does this help? We will not accept any pull requests regarding formatting.

ondfisk commented 11 years ago

Also, upgrading the project to .NET 4.5 breaks compatibility with users still on 4.0. Since there are no new features from 4.5 currently in C5 this is not going to happen now.

T145 commented 11 years ago

Well, the formatting wasn't for my personal preference; it's a universal format that a lot of people use and one that I thought would be familiar to anyone trying to edit the code. The formatting that's there now is horribly inconsistent, and many editors will do funky indentations in a whole lot of those files. There's also a lot of trailing whitespaces.

Removing the .gitattributes allows for formatting to remain consistent. If you're switching between Visual Studio and MonoDevelop for example, the lines will remain consistent, especially since a lot of background software manages the line endings for you.

The .gitignore was FULL of stuff that didn't need to be there. For example, there is absolutely no Python in this project.