search

sestoft / C5

C5 generic collection library for C#/.NET
http://www.itu.dk/research/c5/
MIT License
1.03k stars 181 forks source link

Add NuGet files for Portable Library Projects #4

Closed dfaivre closed 12 years ago

dfaivre commented 12 years ago

C5 cannnot be added through nuget to a Portable Library project. Since it looks like the C5 library is built as a Portable Library, this should be possible by adding C5 to the parent "lib" folder in the nuget package:

... `

` ...

Let me know if I can help out -- great project!

David Faivre

ondfisk commented 12 years ago

Hi David,

I tried to update the nuspec accordingly and now I get these warnings during pack:

WARNING: 2 issue(s) found with package 'C5'.

Issue: Assembly not inside a framework folder. Description: The assembly 'lib\C5.dll' is placed directly under 'lib' folder. It is recommended that assemblies be placed inside a framework-specific folder. Solution: Move it into a framework-specific folder. If this assembly is targeted for multiple frameworks, ignore this warning.

Issue: Invalid framework folder. Description: The folder '.NETPortable40-Profile1' under 'lib' is not recognized as a valid framework name. Solution: Rename it to a valid framework name.

Do you know if there's any solution to that - or will we just have to leave it be and wait for Ebbo to update NuGet to be portable library aware?

Med venlig hilsen / Best regards

rasmus NIELSEN tel: +45 27 28 11 54 e-mail: rasmus@dehler-nielsen.commailto:rasmus@dehler-nielsen.com internet: www.dehler-nielsen.comhttp://www.dehler-nielsen.com/

On 02/02/2012, at 22.39, dfaivre wrote:

C5 cannnot be added through nuget to a Portable Library project. Since it looks like the C5 library is built as a Portable Library, this should be possible by adding C5 to the parent "lib" folder in the nuget package:

...

...

Let me know if I can help out -- great project!

David Faivre

Reply to this email directly or view it on GitHub: https://github.com/sestoft/C5/issues/4

dfaivre commented 12 years ago

Rasmus --

For the NuGet packages I've had that are "portable", I just ignore the error about being outside a framework folder, and it works as expected. I haven't tried to do anything with ".NETPortable40-Profile1" though.

Great library -- thanks for your work!

On Thu, Feb 16, 2012 at 2:31 AM, Rasmus Nielsen < reply@reply.github.com

wrote:

Hi David,

I tried to update the nuspec accordingly and now I get these warnings during pack:

WARNING: 2 issue(s) found with package 'C5'.

Issue: Assembly not inside a framework folder. Description: The assembly 'lib\C5.dll' is placed directly under 'lib' folder. It is recommended that assemblies be placed inside a framework-specific folder. Solution: Move it into a framework-specific folder. If this assembly is targeted for multiple frameworks, ignore this warning.

Issue: Invalid framework folder. Description: The folder '.NETPortable40-Profile1' under 'lib' is not recognized as a valid framework name. Solution: Rename it to a valid framework name.

Do you know if there's any solution to that - or will we just have to leave it be and wait for Ebbo to update NuGet to be portable library aware?

Med venlig hilsen / Best regards

rasmus NIELSEN tel: +45 27 28 11 54 e-mail: rasmus@dehler-nielsen.commailto:rasmus@dehler-nielsen.com internet: www.dehler-nielsen.comhttp://www.dehler-nielsen.com/

On 02/02/2012, at 22.39, dfaivre wrote:

C5 cannnot be added through nuget to a Portable Library project. Since it looks like the C5 library is built as a Portable Library, this should be possible by adding C5 to the parent "lib" folder in the nuget package:

...

...

Let me know if I can help out -- great project!

David Faivre

Reply to this email directly or view it on GitHub: https://github.com/sestoft/C5/issues/4

Reply to this email directly or view it on GitHub: https://github.com/sestoft/C5/issues/4#issuecomment-3996887

ondfisk commented 12 years ago

Thanks.

The .NETPortable40-Profile1 thingy is a Portable Library supporting all profiles.

Anyway I've updated the NuGet package as you requested and it can now be included in a portable library itself.

Med venlig hilsen / Best regards

rasmus NIELSEN tel: +45 27 28 11 54 e-mail: rasmus@dehler-nielsen.commailto:rasmus@dehler-nielsen.com internet: www.dehler-nielsen.comhttp://www.dehler-nielsen.com/

On 16/02/2012, at 15.22, dfaivre wrote:

Rasmus --

For the NuGet packages I've had that are "portable", I just ignore the error about being outside a framework folder, and it works as expected. I haven't tried to do anything with ".NETPortable40-Profile1" though.

Great library -- thanks for your work!

On Thu, Feb 16, 2012 at 2:31 AM, Rasmus Nielsen < reply@reply.github.commailto:reply@reply.github.com wrote:

Hi David,

I tried to update the nuspec accordingly and now I get these warnings during pack:

WARNING: 2 issue(s) found with package 'C5'.

Issue: Assembly not inside a framework folder. Description: The assembly 'lib\C5.dll' is placed directly under 'lib' folder. It is recommended that assemblies be placed inside a framework-specific folder. Solution: Move it into a framework-specific folder. If this assembly is targeted for multiple frameworks, ignore this warning.

Issue: Invalid framework folder. Description: The folder '.NETPortable40-Profile1' under 'lib' is not recognized as a valid framework name. Solution: Rename it to a valid framework name.

Do you know if there's any solution to that - or will we just have to leave it be and wait for Ebbo to update NuGet to be portable library aware?

Med venlig hilsen / Best regards

rasmus NIELSEN tel: +45 27 28 11 54 e-mail: rasmus@dehler-nielsen.commailto:rasmus@dehler-nielsen.com internet: www.dehler-nielsen.comhttp://www.dehler-nielsen.com/

On 02/02/2012, at 22.39, dfaivre wrote:

C5 cannnot be added through nuget to a Portable Library project. Since it looks like the C5 library is built as a Portable Library, this should be possible by adding C5 to the parent "lib" folder in the nuget package:

...

...

Let me know if I can help out -- great project!

David Faivre

Reply to this email directly or view it on GitHub: https://github.com/sestoft/C5/issues/4

Reply to this email directly or view it on GitHub: https://github.com/sestoft/C5/issues/4#issuecomment-3996887

Reply to this email directly or view it on GitHub: https://github.com/sestoft/C5/issues/4#issuecomment-4001439