Open lundmikkel opened 8 years ago
In ArrayListTest events are not properly tested. The method listen() only adds event handlers to the Added event, thereby ignoring all other events:
ArrayListTest
listen()
Added
private void listen() { seen.Listen(list, EventTypeEnum.Added); }
This is correctly done in the HashedArrayListTest class:
HashedArrayListTest
private void listen() { seen.Listen(list, EventTypeEnum.All); }
Be aware that fixing the listen() method will cause the Listenable() test to fail. It can, however, easily be fixed by inlining the method:
Listenable()
[Test] public void Listenable() { Assert.AreEqual(EventTypeEnum.All, list.ListenableEvents); Assert.AreEqual(EventTypeEnum.None, list.ActiveEvents); seen.Listen(list, EventTypeEnum.Added); // <-- Bug fix Assert.AreEqual(EventTypeEnum.Added, list.ActiveEvents); }
Again. Pull requests are accepted :)
In
ArrayListTest
events are not properly tested. The methodlisten()
only adds event handlers to theAdded
event, thereby ignoring all other events:This is correctly done in the
HashedArrayListTest
class:Be aware that fixing the
listen()
method will cause theListenable()
test to fail. It can, however, easily be fixed by inlining the method: