search

sestoft / C5

C5 generic collection library for C#/.NET
http://www.itu.dk/research/c5/
MIT License
1.03k stars 181 forks source link

NetCore support #50

Closed Davidblkx closed 7 years ago

ondfisk commented 8 years ago

Hi David, If you inspect the other projects in C5, you'll notice that files are linked not added (compare C5 vs C5.NET40 for instance). Have you changed anything in the files you've added?

Also don't check in the .lock.json file and other generated stuff.

If you can update your request I'll gladly accept it.

pmunin commented 7 years ago

any updates on this pull request? @ondfisk as far as I know .NET Core project.json does not allow to link files, so it has to be copied :disappointed:

ondfisk commented 7 years ago

.NET Core and .NET Standard have moved (back) to .csproj so I've added a C5.NETCore and a C5.NETStandard project. Not sure if both are needed - does that help? (Haven't updated NuGet yet)

pmunin commented 7 years ago

Oh I heard they only plan to, didn't know it was decided. Yeah just to be safe it's better to have both there.

VitaliiTsilnyk commented 7 years ago

You don't have to target netcoreapp for a library, it's designed only for executable projects. Also, please don't just target the highest version of netstandard. Use the minimum required version (for your library, I think it would be netstandard1.3) so the projects targeting lover standard versions can use it.

llint commented 7 years ago

Any status updates on a (possible) beta release of the dotnet core/standard support on NuGet.org?