Inconsistent default constructors

sestoft / C5

C5 generic collection library for C#/.NET

http://www.itu.dk/research/c5/

MIT License

1.03k stars 180 forks source link

Inconsistent default constructors #67

Closed FruitcakeElemental closed 4 years ago

FruitcakeElemental commented 6 years ago

Hi Guys,

I've noticed a few collections are inconsistent whether they define a default constructor or not, this can have implications for things like the new() generic constraint.

I've created a patch that adds a default constructor to the ones that I found were missing, diff attached.

[default_constructor.diff.txt] (https://github.com/sestoft/C5/files/1680304/default_constructor.diff.txt) [default_constructor.diff.txt]

ondfisk commented 6 years ago

Please submit as a pull request and we'll have a look at it.

FruitcakeElemental commented 6 years ago

Can do, do i need permissions added to the project? its telling me i can't push to the repo.

Its my first open source contribution so i might be missing some knowledge.

ondfisk commented 6 years ago

No permissions needed. You fork the repo and create a pull request: https://help.github.com/articles/creating-a-pull-request/

FruitcakeElemental commented 6 years ago

Created pull request: https://github.com/sestoft/C5/pull/68

ondfisk commented 4 years ago

Issue should be fixed in latest beta