search

sethaxen / ExponentialAction.jl

Compute the action of the matrix exponential
MIT License
24 stars 0 forks source link

Fix error for large matrix norm #11

Closed sethaxen closed 2 years ago

sethaxen commented 2 years ago

Fixes #10

@aelmokadem can you confirm this fixes your issue?

codecov[bot] commented 2 years ago

Codecov Report

Merging #11 (16e560e) into main (a1e6801) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   98.61%   98.63%   +0.01%     
==========================================
  Files           4        4              
  Lines          72       73       +1     
==========================================
+ Hits           71       72       +1     
  Misses          1        1
Impacted Files Coverage Δ
src/parameters.jl 97.36% <100.00%> (+0.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1e6801...16e560e. Read the comment docs.

aelmokadem commented 2 years ago

Is what I need to do to get that fix os to update the package and it would pull it?

sethaxen commented 2 years ago

Is what I need to do to get that fix os to update the package and it would pull it?

After an hour or so when v0.1.4 is released, yes, that would work. Or you could do

] add ExponentialActions#main

which would pull in the fix from the main branch.

aelmokadem commented 2 years ago

Yup.. that indeed fixed the issue. Thank you so much @sethaxen :)

sethaxen commented 2 years ago

Glad to hear it! And, you're welcome!