search

sethaxen / MRCFile.jl

Read and write files and manipulate data in the MRC2014 format
Other
16 stars 4 forks source link

Fix bug and add consistency tests. #20

Closed shuuul closed 1 year ago

shuuul commented 1 year ago
shuuul commented 1 year ago

Hi @sethaxen , can you adjust the CI workflow? It seems only to fail on the Linux platform.

sethaxen commented 1 year ago

Thanks for the tests and fixes! I'm vacationing this week and won't have time to look into this until next week.

I wonder though if PythonCall and CondaPkg instead of PyCall and Conda would be more suitable for the tests. The main differences are that with CondaPkg you add a CondaPkg.toml file that specifies the Python deps and their version bounds, and these are placed always in a fresh Conda env (Conda.jl always uses a global one). Unlike PyCall, PythonCall doesn't convert anything to/from a Julia type unless explicitly requested.

codecov[bot] commented 1 year ago

Codecov Report

Merging #20 (f41d85f) into main (f82d9f5) will increase coverage by 2.87%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   84.98%   87.85%   +2.87%     
==========================================
  Files           6        6              
  Lines         313      313              
==========================================
+ Hits          266      275       +9     
+ Misses         47       38       -9
Impacted Files Coverage Δ
src/header.jl 86.50% <100.00%> (ø)
src/io.jl 93.75% <100.00%> (+11.25%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

shuuul commented 1 year ago

Thanks for your suggestion! I just rewrote the test part. Have a nice vacation!