search

sethfair / logseq-focus-mode

The Focus Mode plugin for Logseq allows you to quickly switch into a distraction-free "zen" mode by toggling into full-screen and hiding elements like the sidebar or properties section.
MIT License
34 stars 4 forks source link

Use native Plugin Settings instead of custom menu #12

Closed MrEbbinghaus closed 1 year ago

MrEbbinghaus commented 2 years ago

Logseq allows for custom Plugin Settings in the Settings Menu: image

focus mode shouldn't introduce an own settings menu, as it adds clutter to the UI and leads to an inconsistent UX.

sethfair commented 2 years ago

Thanks for bringing this to my attention.

sethfair commented 2 years ago

@MrEbbinghaus which version are you using? I am not seeing the plugin settings in the latest nightly build of Logseq.

sethfair commented 2 years ago

image

MrEbbinghaus commented 2 years ago

I am on Version 0.6.6

Maybe it only appears, if you have at least one plugin that defines custom settings?

Here is an example of custom settings in the writegood plugin https://github.com/hkgnp/logseq-writegood-plugin/blob/master/src/callSettings.ts

image

MrEbbinghaus commented 2 years ago

Yes, the settings are only displayed under certain circumstances. https://github.com/logseq/logseq/blob/master/src/main/frontend/components/settings.cljs#L654

sethfair commented 1 year ago

@MrEbbinghaus the latest version v1.0 now has this. Let me know how it works for you.