sethforprivacy / simple-monerod-docker

A simple and straightforward Dockerized monerod built from source and exposing standard ports.
https://sethforprivacy.com/guides/run-a-monero-node/
MIT License
92 stars 19 forks source link

Use `get_height` for health check #112

Closed SamsungGalaxyPlayer closed 4 months ago

SamsungGalaxyPlayer commented 4 months ago

https://github.com/sethforprivacy/simple-monerod-docker/blob/ab316cb1809b34fc7aa6035a212a379b397aa9eb/Dockerfile#L190

get_height is significantly less resource intensive than get_info.

sethforprivacy commented 4 months ago

Ah, amazing, had no idea!

Merged in https://github.com/sethforprivacy/simple-monerod-docker/commit/3a7ec6abed0fa4900c27e6f28d642aaecb66ce9b

hundehausen commented 4 months ago

I made some tests with Postman. I see similar response times for both calls, but get_height is smaller in terms of bytes.