sethhall / chromium-compact-language-detector

Automatically exported from code.google.com/p/chromium-compact-language-detector
0 stars 0 forks source link

distutils requires libcld.a to be built separately to compile the python extension #5

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Right now it's required to build libcld.a separately in order to compile the 
python extension.
This is a problem for example when installing through pip by pointing it 
directly at the repository url (would be a problem if the package would be 
uploaded on pypi too).
The resulting module is not much larger (1.6Mb of the resulting module vs 1.4Mb 
of the original module in a 64bit environment) and noticeably simplifies the 
install procedure.

The attached patch allows the python's module to be built using only the 
setup.py script. Building cld as a standalone library remains possible, the 
patch only changes the distutils build script.

Original issue reported on code.google.com by giulian...@gmail.com on 3 Jan 2012 at 2:08

Attachments:

GoogleCodeExporter commented 9 years ago
Makes sense -- I just committed.  Thanks!

Original comment by luc...@mikemccandless.com on 3 Jan 2012 at 2:39

GoogleCodeExporter commented 9 years ago

Original comment by luc...@mikemccandless.com on 13 Jan 2012 at 12:01