sethjuarez / numl

Machine Learning for .NET
http://numl.net
MIT License
430 stars 104 forks source link

Guid property #51

Closed robin-karlsson closed 8 years ago

robin-karlsson commented 8 years ago

I needed a guid property, and I implemented it for my solution. But I was thinking that maybe someone else might be interested in that. Should I prepare a PR for that? Or do you want to keep the core stuff as slim as possible?

sethjuarez commented 8 years ago

sure - why the addition?

robin-karlsson commented 8 years ago

We have a whole bunch objects with Guid identifiers from the database. With features and labels as Guid we can use those identifiers directly. Really neat for our use case so far.

sethjuarez commented 8 years ago

My sense is that a guid property would not be predictive enough to make a difference in any given model (I could be wrong....)

bdschrisk commented 8 years ago

Theoretically it would work the same way as a string category type. At prediction time we'd just map the output to a Guid, like we do with strings. ~ Thoughts?

robin-karlsson commented 8 years ago

52

sethjuarez commented 8 years ago

Yeah - totally get this now. Great idea - just merged a bit ago.