Vaport not Compatible with Ghost 0.4.2 Maintenance Release

[cfl0ws]

It looks like my hosted blog (cjremus.ghost.io) at ghost.org was just updated to the 0.4.2 Maintenance Release and that new release may have broken the Vapor theme. Could it be that the Vapor theme's not compatible w/the 0.4.2 release? Nothing else that I'm aware of has changed on my installation. Please let me know if you need any additional info to troubleshoot, happy to help out where I can. Thanks..Chris

[sethlilly]

It may be. I haven't had a chance to look since the 0.4.2 update was released, but I plan to do so ASAP.

On Wednesday, March 26, 2014, cjremus notifications@github.com wrote:

It looks like my hosted blog (cjremus.ghost.io) at ghost.org was just updated to the 0.4.2 Maintenance Release and that new release may have broken the Vapor theme. Could it be that the Vapor theme's not compatible w/the 0.4.2 release? Nothing else that I'm aware of has changed on my installation. Please let me know if you need any additional info to troubleshoot, happy to help out where I can. Thanks..Chris

— Reply to this email directly or view it on GitHubhttps://github.com/sethlilly/Vapor/issues/25 .

Seth

[cfl0ws]

Thanks. I think that's what's going on here. Let me know if you'd like me to test the new build when its ready on the hosted platform. Rolled back to the default theme for now...

---

http://cjremus.ghost.io http://cjrcycl.es

Twitter - @cjremus & @cjrcycles

On Wed, Mar 26, 2014 at 4:02 PM, Seth Lilly notifications@github.comwrote:

It may be. I haven't had a chance to look since the 0.4.2 update was released, but I plan to do so ASAP.

On Wednesday, March 26, 2014, cjremus notifications@github.com wrote:

It looks like my hosted blog (cjremus.ghost.io) at ghost.org was just updated to the 0.4.2 Maintenance Release and that new release may have broken the Vapor theme. Could it be that the Vapor theme's not compatible w/the 0.4.2 release? Nothing else that I'm aware of has changed on my installation. Please let me know if you need any additional info to troubleshoot, happy to help out where I can. Thanks..Chris

Reply to this email directly or view it on GitHub< https://github.com/sethlilly/Vapor/issues/25> .

Seth

Reply to this email directly or view it on GitHubhttps://github.com/sethlilly/Vapor/issues/25#issuecomment-38732292 .

[cfl0ws]

Here's a comment from the Ghost Forums that I thought might be helpful -

[sethlilly]

No Isotope in Vapor, but I'm glad to know I'm not the only one behind on implementing changes. I'll work on those this weekend. Thanks for sharing!

On Fri, Mar 28, 2014 at 7:21 AM, cjremus notifications@github.com wrote:

Here's a comment from the Ghost Forums that I thought might be helpful - [image: 2014-03-28 07 21 02 am]https://cloud.githubusercontent.com/assets/6430200/2548921/27df14ce-b66b-11e3-8f1b-c05b442a49e9.png

— Reply to this email directly or view it on GitHubhttps://github.com/sethlilly/Vapor/issues/25#issuecomment-38909329 .

[ErisDS]

@cjremus Can you post some details about what it is that has actually broken? I wasn't expecting any compatibility issues, which means either we missed something, or there is a bug somewhere and either way I'd like to get a handle on it.

I just tried out Vapor on my local blog, and it all seems fine - so perhaps there is something Ghost(Pro) specific going on - either way any details you can provide would be great :+1:

[sethlilly]

@cjremus I'm pulling @ErisDS into this thread just to keep her updated on progress since she inquired about the issue on Twitter.

[sethlilly]

@ErisDS As I mentioned on Twitter, I'm running Vapor on seth.ghost.io without incident, though I only have one post there now. I'm admittedly behind in implementing changes like asset helpers, but that shouldn't break anything, should it?

[ErisDS]

Nothing should have broken. That doesn't mean it didn't, but you know I try to keep all the theme devs up to speed, and we try to introduce backwards incompatible changes slowly (like how we've deprecated pageUrl in 0.4.2 - it now shows a warning message, but it won't actually do any harm until 0.6) so I'm keen to get on top of whatever has happened.

I've tried Vapor out locally and on a test blog on Ghost(Pro) and I can't see any problems, so I'm very interested to get some details from @cjremus

[sethlilly]

Yes, of course, @ErisDS. I apologize to you and the Ghost community for not updating as quickly as I had planned. Things have been busy here, and open source (read: free) work took a hit. Thanks for being so involved. As I've said before, that interaction is critical for dev engagement.

@cjremus Let me know what's happening and I'll dig into it. Thanks for your willingness to help troubleshoot these issues!

[cfl0ws]

The problem I had was losing all formatting. Like I said in my original message, I think, however am not positive, that the upgrade was the problem, since nothing else had changed. Attahched the version I was using. Come to think of it, I did modify my version to include Google Analytics and Disqus. However that version was running fine until the time of the upgrade. I can try and change my theme back to Vapor later today or tomorrow to see if it's working again. I unfortunately won't be able to do much more until then. If nobody else is experiencing this, it could very well be something on my end, however I can't really figure out what that would be right now.

---

http://cjremus.ghost.io http://cjrcycl.es

Twitter - @cjremus & @cjrcycles

On Fri, Mar 28, 2014 at 9:31 AM, Hannah Wolfe notifications@github.comwrote:

Nothing should have broken. That doesn't mean it didn't, but you know I try to keep all the theme devs up to speed, and we try to introduce backwards incompatible changes slowly (like how we've deprecated pageUrlin 0.4.2 - it now shows a warning message, but it won't actually do any harm until 0.6)

I've tried Vapor out locally and on a test blog on Ghost(Pro) and I can't see any problems, so I'm very interested to get some details from @cjremushttps://github.com/cjremus

Reply to this email directly or view it on GitHubhttps://github.com/sethlilly/Vapor/issues/25#issuecomment-38918676 .

[ErisDS]

@cjremus attachments don't come through to GitHub. I'm starting to think this may have been a cache problem - but I'd need to see what version of Vapor you were using.

When you have problems like this on Ghost(Pro) please email support[at]ghost[dot]org - we're always on hand to give you personalised support for your blog. It could well have been a problem with your blog misbehaving after the upgrade.

[cfl0ws]

@ErisDS @sethlilly Just uploaded the theme again and am getting the same strange formatting behavior.

Hopefully that image comes through, I'll also leave the blog as is for now, before rolling back to Casper in a few hours...I'm happy to transfer this help request over to support @ ghost if we all agree that's the right thing to do at this point. Please just let me know.

[sethlilly]

@cjremus Looks good here: http://cl.ly/image/0q422B1M3w3R

[cfl0ws]

@sethlilly @erisds Looks like it might have something to do with Chrome. When I originally reported the issue, I tried on my laptop and phone, both using the Chrome browser. I still lose the formatting using Chrome on my laptop and phone. It seems to be working correctly on Safari, both on my laptop and phone.

---

http://cjremus.ghost.io http://cjrcycl.es

Twitter - @cjremus & @cjrcycles

On Fri, Mar 28, 2014 at 3:18 PM, Seth Lilly notifications@github.comwrote:

@cjremus https://github.com/cjremus Looks good here: http://cl.ly/image/0q422B1M3w3R

Reply to this email directly or view it on GitHubhttps://github.com/sethlilly/Vapor/issues/25#issuecomment-38957961 .

[sethlilly]

@cjremus Looks good in Chrome 34.0.1847.92 beta, OS X 10.9.2. Haven't yet tried it on Chrome for Android or Windows. Can you look at the console in Chrome and see if it's throwing any errors surrounding CSS or loading styles?

[sethlilly]

@cjremus I saw your console screenshot, though it isn't appearing here in GitHub. I've verified that http://cjremus.ghost.io/assets/css/screen.css, http://cjremus.ghost.io/assets/css/normalize.css and http://cjremus.ghost.io/assets/js/index.js appear correctly here. Can you visit those in your Chrome install?

[ErisDS]

@cjremus can you please try in an incognito window in Chrome?

[ErisDS]

I'm reasonably certain that this is a caching problem. To provide some clarity / reasoning, the {{asset}} helper that we added in 0.4.1 adds a query string to all css & js files, so that when Ghost is upgraded or those files are otherwise changed, the query string changes, and any caches know that they need to fetch a new resource.

Vapor doesn't support this yet so anyone who has those resources cached will need to clear their browser cache to see the new versions of the resources.

This would explain why @cjremus sees something different to me/@sethlilly as we didn't visit his site and cache those resources prior to the upgrade.

[sethlilly]

Again, I apologize. The {{asset}} helper update for Vapor should prevent this in the future. Thanks for your work on this, @cjremus and @ErisDS.

[ErisDS]

@sethlilly wasn't intended as a dig :wink: Ghost moves fast, it's pretty hard keeping up!

[sethlilly]

And not taken as such, @ErisDS. :) I just want to make sure Vapor is a solid, open theme that allows people to easily have a great-looking Ghost blog.

[cfl0ws]

@sethlilly @erisds Yes, it looks like it was a cache issue. I tried in an Incognito tab, which worked, then cleared my cache, which did the trick in my browser. Does this mean that anyone who comes to the blog that's visited before will also see the lost formatting, if they haven't cleared their cache? Thanks to both of you for your help and happy that my blog is looking like Vapor again :)

---

http://cjremus.ghost.io http://cjrcycl.es

Twitter - @cjremus & @cjrcycles

On Sat, Mar 29, 2014 at 10:06 AM, Seth Lilly notifications@github.comwrote:

And not taken as such, @ErisDS. :) I just want to make sure Vapor is a solid, open theme that allows people to easily have a great-looking Ghost blog.

On Saturday, March 29, 2014, Hannah Wolfe notifications@github.com wrote:

@sethlilly https://github.com/sethlilly wasn't intended as a dig [image: :wink:] Ghost moves fast, it's pretty hard keeping up!

Reply to this email directly or view it on GitHub< https://github.com/sethlilly/Vapor/issues/25#issuecomment-38996377> .

Reply to this email directly or view it on GitHubhttps://github.com/sethlilly/Vapor/issues/25#issuecomment-38996427 .

[sethlilly]

Fixed in 1.4. Download it now!