sethlilly / Vapor

A minimal, responsive theme for Ghost.
MIT License
544 stars 214 forks source link

Menu margins #30

Closed tobytes closed 9 years ago

tobytes commented 10 years ago

I can't see any reason for the "margin:0" on the last list element in the menu. Especially if you have to fix the uneven margins with an empty list element (hipsterghost.com). Here is a Link to my work in progress blog with the fix: http://tobyte.libra.uberspace.de/

Thanks for this great theme. :)

sethlilly commented 10 years ago

Thanks! This is actually fixed in 1.5, coming soon.

On Wednesday, May 7, 2014, tobytes notifications@github.com wrote:

I can't see any reason for the "margin:0" on the last list element in the menu. Especially if you have to fix the uneven margins with an empty list element (hipsterghost.com). Here is a Link to my work in progress blog with the fix: http://tobyte.libra.uberspace.de/

Thanks for this great theme. :)

You can merge this Pull Request by running

git pull https://github.com/tobytes/Vapor menufix

Or view, comment on, or merge it at:

https://github.com/sethlilly/Vapor/pull/30 Commit Summary

  • Activated menu, deactivated header description
  • Fixed margins
  • revert to original code

File Changes

  • M assets/css/screen.csshttps://github.com/sethlilly/Vapor/pull/30/files#diff-0(3)
  • M assets/css/screen.lesshttps://github.com/sethlilly/Vapor/pull/30/files#diff-1(3)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/sethlilly/Vapor/pull/30 .

Seth

tobytes commented 10 years ago

Alright, thanks. I'm looking forward to play with a new version.