search

sethmlarson / truststore

Verify certificates using OS trust stores
https://truststore.readthedocs.io
MIT License
151 stars 18 forks source link

Mark tests as requiring Internet #120

Closed stefanor closed 10 months ago

stefanor commented 10 months ago

So that we can self-contained tests, when offline.

The use-case here is packaging truststore in Debian. We like to run tests during our package builds, where possible. These build environments don't permit Internet access. We do have CI test environments that can access the Internet, but those happen after build. We'd run the full test suite there (inclnuding mkcert, which messes with the system certificate store).

I see that the vast majority of the tests require Internet access, so I understand if you're not interested in this patch, because you aren't expecting much low-level test coverage.

sethmlarson commented 10 months ago

@stefanor Could you run nox -s format and push the results?

stefanor commented 10 months ago

thanks for contributing this and for repackaging Truststore into Debian.

No problem. You're a new (vendored) dependency of pip. So I want to have truststore packaged in the archive.