search

sethmlarson / truststore

Verify certificates using OS trust stores
https://truststore.readthedocs.io
MIT License
151 stars 18 forks source link

Test on Windows and macOS #137

Closed sethmlarson closed 4 months ago

notatallshaw commented 4 months ago

FYI, cffi needs to be installed from Github source for Python 3.13 until their next release, like in this PR: https://github.com/pypa/pip/pull/12620

sethmlarson commented 4 months ago

@notatallshaw Thanks for the link, I'll give that a try :)

sethmlarson commented 4 months ago

@davisagli I believe what's happening is that we're seeing one type (bytes) from get_unverified_chain() for MemoryBIO and another type (_ssl.Certificate) from SSLSocket which is why I added the isinstance check.

sethmlarson commented 4 months ago

@davisagli Definitely, here's the upstream issue: https://github.com/python/cpython/issues/118658