search

sethmlarson / truststore

Verify certificates using OS trust stores
https://truststore.readthedocs.io
MIT License
147 stars 18 forks source link

[drive-by CI improvement suggestion] Implement a unified gate check for branch protection #140

Open webknjaz opened 2 months ago

webknjaz commented 2 months ago

I have a thing (https://github.com/marketplace/actions/alls-green#why — a shameless plug; you might've seen it integrated in CPython, pip, cryptography, etc.) that allows consolidating results of CI matrixes into a single gate.

The reason I'm bringing this up is that I noticed that only a portion of jobs are marked as required in PRs so it is likely that updating branch protection after updating the CI job definitions slipped off the radar.

This could be a good first issue for an external contributor, requiring just a little GHA experience.

davisagli commented 2 months ago

Thanks @webknjaz. Updating the branch protection rules requires admin permissions on the repository, so I think @sethmlarson has to do it.

webknjaz commented 2 months ago

The workflow/job definition can be implemented separately. But the final bit would require an admin, yes.

davisagli commented 2 months ago

@webknjaz Ah, I misunderstood -- you're not merely proposing adding the jobs that are currently not required, but adding your tool to help make sure this doesn't need as much maintenance in the future. That sounds interesting to me.