seths10 / Quotes-Generator

website for generating random quotes
GNU General Public License v2.0
46 stars 117 forks source link

Add More Quotes #2

Closed seths10 closed 1 year ago

seths10 commented 2 years ago

Hi 👋,

Please go ahead and add more quotations to the quotes.js file under the js folder.

🎯 Goal To get more quotations on the website

Please make sure your PR passes the following:

bruceyboy86 commented 2 years ago

Happy hacktoberfest! Can I be assigned this issue please? :)

STM3900 commented 2 years ago

Hello, can I help too? :)

Irjean commented 2 years ago

Hello, can I assist too? :)

codeboyfriend commented 2 years ago

Can I add more

seths10 commented 2 years ago

contribution is welcomed

On Mon, 3 Oct 2022, 23:13 Michael, @.***> wrote:

Can I add more

— Reply to this email directly, view it on GitHub https://github.com/seths10/Quotes-Generator/issues/2#issuecomment-1266182977, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOCLTWXE7Y3REWQZ6NMADBLWBNSDFANCNFSM6AAAAAAQ362OLU . You are receiving this because you authored the thread.Message ID: @.***>

seths10 commented 2 years ago

Happy hacktoberfest! Can I be assigned this issue please? :)

you can go ahead and add more, submit a pull request and I will merge it

seths10 commented 2 years ago

Can I add more

yes you can

madfarizki commented 2 years ago

Hi @seths10, I'v added some quotes, please check my pull request #9

adityaacse commented 2 years ago

Hi @seths10, I have added some quotes, please check my PR.

HeYPoonam commented 2 years ago

Hi @seths10 , I have added more quotes please accept my PR https://github.com/seths10/Quotes-Generator/pull/51

seths10 commented 2 years ago

@HeYPoonam and @adityaacse I've merged your commits

animagus12 commented 2 years ago

Hey, Can I assist?

seths10 commented 2 years ago

@animagus12 are u asking if you can add more quotes?

darkling10 commented 2 years ago

Hiii,can I also add some quotes???

Sathasivamthirumoorthi commented 2 years ago

can i add some more quotes ?

Vishal2002 commented 2 years ago

Instead of more quotes can we use Quotes API.

TrlRizu commented 2 years ago

Hey @seths10, I added 34 quotes and fixed indentations, and deleted 2 repeated quotes. I'd appreciate it if you merge my PR https://github.com/seths10/Quotes-Generator/pull/105

seths10 commented 2 years ago

@Vishal2002 No please, we want beginners to be able to contribute to the repo. Using an API will limit that

SnehaNarendran01071998 commented 2 years ago

hey @seths10, I have added another quote. Please review the PR

Vishal2002 commented 2 years ago

Bro @seths10 Please review my PR and merge them.

Vishal2002 commented 2 years ago

Bro Please merge the PR

Ibadmoin commented 1 year ago

Can I add more quotes and delete the repeated ones...

seths10 commented 1 year ago

Yes you can @Ibadmoin

MojoBoingo commented 1 year ago

I'll add some more too.