sethteo / pe

0 stars 0 forks source link

Unclear method calls for filter command #12

Open sethteo opened 2 months ago

sethteo commented 2 months ago

Screenshot 2024-04-19 at 5.23.43 PM.png

No class indicated which calls the "parse", "executes" method as well as where their return values are headed to.

soc-se-bot commented 2 months ago

Team's Response

Thanks for the feedback! From what I recall, it is not compulsory to indicate that. Screenshot 2024-04-22 113513.png This picture is one I took from the course website, it does not indicate which class is calling the first methods or where their return values are headed either! I did not include logic manager as I only documented parts that I had added, while logic manager had been documented in earlier parts. Hence a new develpoer should already know that logic manager is the one calling the parse.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]