search

sethtrain / raven-clj

A Clojure interface to Sentry
84 stars 29 forks source link

use prone to retrieve better frames #10

Closed piranha closed 8 years ago

martinklepsch commented 8 years ago

Hey @piranha this looks good. Are you still interested in getting this merged? @sethtrain was so kind to add me as a collaborator so I would be able to merge this.

I wonder if it would make sense to add some tests? Or do you think the important bits are already tested in the prone tests?

piranha commented 8 years ago

I'm not exactly sure what to test, to be honest. Prone tests itself well, so yeah, not sure if it's necessary.

martinklepsch commented 8 years ago

That's totally fine too, was just a thought :) Thanks for updating the PR 👍

martinklepsch commented 8 years ago

This is now released as 1.4.0: https://github.com/sethtrain/raven-clj#changes 🎉

martinklepsch commented 8 years ago

Ugh, just spotted a mistake, will release 1.4.1 shortly.

martinklepsch commented 8 years ago

Ok, 1.4.1 released with actual dependency on Prone. Please report any bugs.

martinklepsch commented 8 years ago

1.4.2 is released with the missing require statements