search

sethtrain / raven-clj

A Clojure interface to Sentry
84 stars 29 forks source link

fix: don't send invalid attributes to sentry server #13

Closed kennethkalmer closed 8 years ago

kennethkalmer commented 8 years ago

Since 8.0 (getsentry/sentry#1746) sentry started showing messages on the screen for invalid attributes sent in the packet.

Currently this client sends ts, uri, project-id, key and secret in the body. This gets reported as an error in the UI. Prior to 8.0 the error would have just been logged and not easily visible to users.

This PR simply dissoc's the keys from the map.

martinklepsch commented 8 years ago

This has been bugging me occasionally so thanks for taking a look & fixing @kennethkalmer! 👏

martinklepsch commented 8 years ago

It might be better to separate the body header arguments to send-packet to make that a bit more obvious but I don't think there's any practical issue with your change so I merged it. If you feel like refactoring that a bit go for it (but keep backwards compatibility in mind).

martinklepsch commented 8 years ago

This is now released as 1.4.0: https://github.com/sethtrain/raven-clj#changes 🎉

martinklepsch commented 8 years ago

Ok, 1.4.1 released with actual dependency on Prone. 😅 Please report any bugs.

martinklepsch commented 8 years ago

😞 ignore what I said, just spotted more issues with #10

martinklepsch commented 8 years ago

1.4.2 is released :)

kennethkalmer commented 8 years ago

Awesome! I was holding back the refactoring until this got merged! Will get another PR through in a few days :)