Body/params is never populated

sethtrain / raven-clj

A Clojure interface to Sentry

84 stars 29 forks source link

Body/params is never populated #19

Closed andrewnguyenism closed 7 years ago

andrewnguyenism commented 8 years ago

Viewing issues for my Clojure projects on Sentry, the "Body" section always shows {}. It seems like its not capturing the request params at all for some reason? The other sections - "Cookies", "Headers" - are filling correctly (although I do have the issue in #15 for sessions).

minimal commented 7 years ago

Looks like it just get :params which is already handled by :query-string, it should probably get :body instead.

https://github.com/sethtrain/raven-clj/blob/63aa06464ed71ec60dd8761301e1b97100d833c0/src/raven_clj/interfaces.clj#L17

andrewnguyenism commented 7 years ago

;; If you want to fully utilize the Http interface you should make sure
;; you use the wrap-params and wrap-keyword-params middlewares to ensure
;; the request data is stored correctly.

Me not reading the manual close enough...