search

sethtrain / raven-clj

A Clojure interface to Sentry
84 stars 29 forks source link

Include ex-data in GetSentry report for the ring wrapper #20

Closed khiemlam closed 7 years ago

khiemlam commented 7 years ago

Our team has added a feature to include the ex-data in the GetSentry report as an extra parameter in the ring wrapper. I was wondering if this is a feature that would be valuable in the core project. If it is, happy to spin up a PR with the changes. It would look something like this commit without our team's specific configuration. Happy to discuss and adjust the PR as needed. Thanks!

cldwalker commented 7 years ago

@martinklepsch Assuming you're one of the maintainers, any thoughts on this? We'd love to contribute if possible

martinklepsch commented 7 years ago

Thanks for pinging again, this seems like a reasonable addition. Happy to take a PR. Didn't look at the commit now (on mobile) but I'm sure it'll be fine 👍

khiemlam commented 7 years ago

@martinklepsch Great! I created this PR https://github.com/sethtrain/raven-clj/pull/21. Let me know if you have any questions or comments. Happy to modify as needed.

martinklepsch commented 7 years ago

Closing in favor of #21