search

sethtrain / raven-clj

A Clojure interface to Sentry
84 stars 29 forks source link

Don't send sentry_timestamp in the header. #28

Closed 15joeybloom closed 4 years ago

15joeybloom commented 4 years ago

Previously sentry_timestamp in the header was sent in the format 2019-12-13 12:02:58.94. This suddenly stopped working on 12/12 around 16:45 CST.

Sentry's documentation (see the Authentication section) says that the sentry_timestamp should be a UNIX timestamp. We tried sending 0 and that worked just fine, but we also tried not sending sentry_timestamp at all and that also worked.

Here is a PR removing sentry_timestamp from the header. What do you think?

martinklepsch commented 4 years ago

Thanks! I think I’d lean towards a PR that keeps sending the timestamp since in some situations that might be helpful information and different from when it was received by sentry (which is what I assume they default to if you don’t provide it).

Would that work for you and would you be open to create a PR for that?

15joeybloom commented 4 years ago

Yeah that works for me! Here's the new version, sending the current time in UNIX format.

15joeybloom commented 4 years ago

FWIW, Sentry acknowledged this issue on their support forum. https://forum.sentry.io/t/string-formatted-timestamp-in-header-no-longer-accepted-by-api-breaking-clojure-raven-library/8383

martinklepsch commented 4 years ago

Thanks, deployed with 1.6.0-alpha4.