search

sethtrain / raven-clj

A Clojure interface to Sentry
84 stars 29 forks source link

Fix a parsing bug for project-id #33

Closed emil0r closed 2 years ago

emil0r commented 2 years ago

Sentry.io has started to give out project numbers that are bigger than an integer. This patch changes the parsing of the project id to a long, instead of an integer.

In addition, the few dependencies that exists are upgraded to the latest version, with a special mention to clj-http-lite. The clj-commons version is used there, as it is maintained.

emil0r commented 2 years ago

Sorry that it took a while. Been a bit busy :)

awebneck commented 2 years ago

Any news on getting this merged and released?

emil0r commented 2 years ago

Ping @martinklepsch :)

martinklepsch commented 2 years ago

@emil0r Thanks for the PR and adjustments & sorry it's been taking so long. I've tried to deploy the new version to Clojars today but am encountering an issue with boot's deploy tooling that I'm not able to get around by pinning Boot to a lower version.

I know this is a stretch but would you be interested in helping get the deployment tooling for this project running again? I'm pretty open as to what tool to use.

I'll also try to not take another 2 weeks to respond again :)

emil0r commented 2 years ago

I can take a look. Looking into boot it seems to be fairly dead. So either lein or the new CLI tools. Do you want to keep boot for the other parts?

martinklepsch commented 2 years ago

I'm open to remove boot if you feel that would be best / easiest going forward. :)

emil0r commented 2 years ago

Noted.

emil0r commented 2 years ago

@awebneck https://github.com/sethtrain/raven-clj/pull/34