search

sethtrain / raven-clj

A Clojure interface to Sentry
84 stars 29 forks source link

Stacktrace tweaks #6

Closed trptcolin closed 10 years ago

trptcolin commented 10 years ago

There are a couple of issues with stacktraces making them less useful than they could be. This PR does the following things.

  1. Put most recent frames at the end Sentry wants them that way ("Frames should be sorted with the most recent caller being the last in the list." from http://sentry.readthedocs.org/en/5.4.5/developer/interfaces/index.html), and displays stacktraces upside-down without this change.
  2. Add classname context to frames This changes the stacktrace output on Sentry's site from this: core.clj in invoke at line 2515 to: core.clj in clojure.core$some.invoke at line 2515 The updated version gives enough context to debug further.
colinrymer commented 10 years ago

:+1:

sethtrain commented 10 years ago

Thanks @trptcolin, I just got in the office for the morning. I will get these merged and cut a release soon.

sethtrain commented 10 years ago

Thanks again! New release (1.1.0) has been cut and is available via clojars.

trptcolin commented 10 years ago

Thanks for getting this out so quickly!

sethtrain commented 10 years ago

My pleasure man, thanks for helping make it better.